👋 Hi! Thank you for contributing to the vLLM project.

💬 Join our developer Slack at https://slack.vllm.ai to discuss your PR in #pr-reviews, coordinate on features in #feat- channels, or join special interest groups in #sig- channels.

Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors.

You ask your reviewers to trigger select CI tests on top of fastcheck CI.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can either: Add ready label to the PR or enable auto-merge.

If you have any questions, please reach out to us on Slack at https://slack.vllm.ai.

🚀

💡 Codex Review

https://github.com/vllm-project/vllm/blob/41c2a72218df813e7725c1fde000b50324e4b57b/docker/Dockerfile.hpu#L44-L56
Only filter torch requirements in HPU Dockerfile

The sed '/^[torch]/d' used when installing build requirements deletes any line whose first character is t, o, r, c or h, not just the torch entries. This means packages such as cmake, regex, and other dependencies are skipped during the image build, making the subsequent pip install of vLLM likely to fail due to missing build tools. The expression should target the whole word (e.g. sed '/^torch/d') or explicitly list the packages to omit so other requirements remain installed.

https://github.com/vllm-project/vllm/blob/41c2a72218df813e7725c1fde000b50324e4b57b/.buildkite/nightly-benchmarks/scripts/run-performance-benchmarks.sh#L140-L151
HPU memory drain loop parses non‑numeric output

In the new HL‑SMI branch of kill_gpu_processes, the expression hl-smi -q | grep "Used" | head -n 1 | awk -F ' ' '{print $3}' typically returns a colon or unit (e.g. the third field of "Used Memory : 1234 MB" is :), so the numeric comparison -ge 1000 raises [: integer expression expected and the loop exits immediately. As a result the script can proceed before HPU memory has been released, causing flakiness in subsequent benchmarks. The parsing should extract the numeric column (e.g. split on ':' and then take the numeric token) before comparing.

This pull request has merge conflicts that must be resolved before it can be
merged. Please rebase the PR, @jakub-sochacki.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork

@DarkLight1337 @khluu @jikunshang , may you help to review and merge, meanwhile,

there are other two PRs related to this one
Ci-infra vllm-project/ci-infra#191
Pytorch integration pytorch/pytorch-integration-testing#94